Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

FR: Include Google Cloud Pub/Sub in distributed tracing #1013

Closed
DazWilkin opened this issue Feb 22, 2018 · 11 comments
Closed

FR: Include Google Cloud Pub/Sub in distributed tracing #1013

DazWilkin opened this issue Feb 22, 2018 · 11 comments

Comments

@DazWilkin
Copy link

DazWilkin commented Feb 22, 2018

Google Cloud Engineer filing on behalf of a Google Cloud customer.

Customer expects distributed tracing flows to span Google Cloud Pub/Sub service.
As favored messaging service for GCP customers, Pub/Sub is a foundational component of many customer solutions and if the service does not integrate tracing spans, this makes OpenCensus (tracing) less useful.

Customers prefers Java although this FR transcends specific runtimes and should be provided for all

Requst Java, Golang initially.

/cc: @mtwo @shahprit

@sebright
Copy link
Contributor

/cc @bogdandrutu @HailongWen

@HailongWen HailongWen self-assigned this Feb 22, 2018
@HailongWen
Copy link
Contributor

Ack. I am on vacation now and might not be able to respond to this timely.

Meanwhile, @DazWilkin please refer to the integration we've done in googleapis/google-cloud-java#2846 which demonstrated some basic ideas of how OpenCensus integrate with GCS.

@DazWilkin
Copy link
Author

DazWilkin commented Feb 22, 2018

@HailongWen Thank you! I'm leaving on vacation tomorrow but I'll pass this along to my customer and will try to find some time to investigate applying this to Pub/Sub when I return.

@bogdandrutu
Copy link
Contributor

@DazWilkin can you tell me more details about this? Does this request imply pub/sub passing internally the cloud trace context and also maybe participate in the trace or just the client library instrumented?

@DazWilkin
Copy link
Author

The customer (and others) want to be able to have traces that span services that span Pub/Sub. So, the former. E.g. App Engine receiving a client request, publishing a message to Pub/Sub that perhaps triggers a GKE service and dumps something onto Spanner.

@bogdandrutu
Copy link
Contributor

@DazWilkin Awesome. This implies some internal discussions as well about instrumenting the Pub/Sub service internally correct?

@DazWilkin
Copy link
Author

DazWilkin commented Feb 23, 2018

Filing this FR is a catalyst for these discussions to begin (if not already) or to help me get folded into them so that I may pursue for this (and all) customers.

@songy23
Copy link
Contributor

songy23 commented Jan 29, 2019

@dinooliva Should we mark this as complete?

@songy23
Copy link
Contributor

songy23 commented Apr 18, 2019

IIUC Cloud Pub-Sub integration in Java is done. Tutorial can be found at https://opencensus.io/integrations/google_cloud/google_cloud_pubsub/java/.

@songy23 songy23 closed this as completed Apr 18, 2019
@deanberris
Copy link

Is there a chance that these convenience functions/types would be implemented in Go/Python?

@songy23
Copy link
Contributor

songy23 commented May 24, 2019

@deanberris Feel free to open a feature request under https://github.com/census-instrumentation/opencensus-specs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants