Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue 47 #49

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Performance issue 47 #49

merged 6 commits into from
Jun 28, 2024

Conversation

cenfun
Copy link
Owner

@cenfun cenfun commented Jun 28, 2024

No description provided.

@cenfun cenfun merged commit 4e48a8b into main Jun 28, 2024
3 of 4 checks passed
@mrazauskas
Copy link
Contributor

mrazauskas commented Jun 30, 2024

@cenfun After this change I am getting OOM on macOS in CI. Reference: https://github.com/tstyche/tstyche/actions/runs/9731886196/job/26857943053#step:7:1

That script is generating console-details and raw reports. Works fine on Windows and Ubuntu, but not on macOS anymore. Very strange.

@cenfun
Copy link
Owner Author

cenfun commented Jun 30, 2024

That is weird. and I don't have the macOS to test it.

@cenfun
Copy link
Owner Author

cenfun commented Jun 30, 2024

@mrazauskas I guess it should be caused by Promise.all because I found there are so many coverage files in coverage\v8-coverage
https://github.com/cenfun/monocart-coverage-reports/blob/main/lib/generate.js#L919

@cenfun
Copy link
Owner Author

cenfun commented Jun 30, 2024

@mrazauskas The latest version caches some data to memory for performance improvement, which may cause OOM. You can try the env options: NODE_OPTIONS: --max-old-space-size=8192 (maybe 4096 is enough)

- run: yarn test:coverage
        env:
          FORCE_COLOR: true
          MCR_LOG_TIME: true
          NODE_OPTIONS: --max-old-space-size=8192

it is passed on macOS, see
https://github.com/cenfun/monocart-coverage-reports/actions/runs/9732874349/job/26859088535

@mrazauskas
Copy link
Contributor

Yes! This does the job. Thanks for taking time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants