Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Submit Celo-specific wallets in official rainbowkit repo #86

Closed
3 of 4 tasks
arthurgousset opened this issue Jan 17, 2024 · 8 comments
Closed
3 of 4 tasks

Submit Celo-specific wallets in official rainbowkit repo #86

arthurgousset opened this issue Jan 17, 2024 · 8 comments

Comments

@arthurgousset
Copy link
Contributor

arthurgousset commented Jan 17, 2024

Todo based on this Github Discussion:

If I understand correctly, we can provide a similar developer experience if we add Celo-specific wallets to rainbowkit's (@rainbow-me/rainbowkit) official wallet list (walletConnectors).

As mentioned, viem already publishes Celo chain configs for mainnet (celo.ts) and alfajores testnet (celoAlfajores.ts).

Seems like the next step is to make a PR to add Celo-specific wallets to rainbowkit, and see if it gets merged.

Originally posted by @arthurgousset in #85 (comment)

Tasks

Preview Give feedback
@aaronmgdr
Copy link
Member

maybe @jeanregisser can help with valora

@arthurgousset
Copy link
Contributor Author

(for future reference)
Configured wallets are here:

export { default as Valora } from "./valora.js";
export { default as CeloWallet } from "./celo-wallet.js";
export { default as CeloTerminal } from "./celo-terminal.js";
export { metaMaskWalletPlus as MetaMask } from "./metamask-with-fee-currency.js";

Source: rainbowkit-celo/wallets/index.ts

@aaronmgdr
Copy link
Member

aaronmgdr commented Feb 15, 2024

  • Celo Wallet aka Othello No longer supports wallet connect so ive marked as complete
  • Celo Terminal -- since the app doesnt have a deep link this connector never really worked as you had to copy and paste the wallet connect url by hand anyway. so the same functionality and experience exist with default wallet connect connector therefore mark as complete
  • MetaMaskwith Fee Currency -- this experiement was closed down and should not be used
  • Valora -- Valora team will handle -- file should be similar to this

@aaronmgdr
Copy link
Member

next write a migration guide

@arthurgousset
Copy link
Contributor Author

Brief ping @jeanregisser: is adding Valora to the official Rainbowkit walletConnectors on your backlog?

We are planning to stop maintaining @celo/rainbowkit-celo and suggest all wallets are added upstream in rainbowkit. In other words, this package is not needed anymore as far as we can see.

@jeanregisser
Copy link
Contributor

jeanregisser commented Mar 27, 2024

Thanks, we'll take a look and will prioritize it.

@aaronmgdr aaronmgdr removed their assignment Mar 29, 2024
@bakoushin
Copy link

@arthurgousset Valora connector is added to Rainbow kit, as well as Celo/Alfajores chains:

https://github.com/rainbow-me/rainbowkit/releases/tag/%40rainbow-me%2Frainbowkit%402.1.6

@aaronmgdr
Copy link
Member

🔥 oh baby when you merge like that...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants