-
Notifications
You must be signed in to change notification settings - Fork 93
help with server-side disconnects in slack-ruby-client #187
Comments
@dblock Celluloid::IO is effectively unmaintained. I would suggest switching to |
I opened slack-ruby/slack-ruby-client#210 maybe someone will contribute. Still, celluloid serves us well rn and I'd like to fix the issue as well. |
Here is (roughly) what we use. https://gist.github.com/ioquatix/c24f107e2cc7f48e571a37e8e93b0cda?ts=2 |
Sorry, not trying to spam, just trying to help with other suggestions :) |
This is still an ongoing problem, so I could still use some help. What I am seeing is that the run loop still sits inside a Debugging messages that are being sent back and forth, next. @tarcieri When you have a second, would you be so kind to share any better logging code that I can add inside the def handle_read(buffer)
logger.debug("#{self.class}##{__method__}") { buffer }
driver.parse buffer
end This produces
Not very useful. I could convert that data to some binary, but that's probably not much better. Maybe there's a parser I should add logging to? Any other recommendations? I tried setting a global celluloid logger and not seeing anything from celluloid-io. Celluloid.logger = ...
Celluloid.logger.level = Logger::DEBUG Thanks. |
Also, is there another driver than https://github.com/faye/websocket-driver-ruby that we should/could be using? |
Coming from slack-ruby/slack-ruby-client#208. The celluloid-io code we have isn't detecting server-side disconnects occasionally. We could really use some professional help, we're likely not using celluloid-io correctly in https://github.com/slack-ruby/slack-ruby-client/blob/master/lib/slack/real_time/concurrency/celluloid.rb#L31
The text was updated successfully, but these errors were encountered: