Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display chapters in progress bar #578

Closed
soredake opened this issue Aug 1, 2020 · 4 comments
Closed

Display chapters in progress bar #578

soredake opened this issue Aug 1, 2020 · 4 comments
Assignees

Comments

@soredake
Copy link

soredake commented Aug 1, 2020

Overview Description:

Steps to Reproduce:

  1. Open file with chapters.
  2. No chapter marks is shown in progress bar.

Actual Results:
No chapter marks is shown in progress bar.

Expected Results:
Show chapter marks like mpv does.
Screenshot_20200801_103453

Version: 0.19-1~focal1

Additional Information: kubuntu 20.04

@ayushdiagarwal
Copy link

+1

@moshiur-raj
Copy link

Recent version of mpv shows the chapter name in the osc. Maybe we can have something like that too?
For example, when the mouse hovers over the progress bar the chapter name is shown beside the timestamp?

@VarLad
Copy link

VarLad commented Jul 26, 2022

Haruna now shows it in the progress bar too.
@gnome-mpv Any idea how easy/hard will it be to implement? Or will we consider it for UI Redesign?

@gnome-mpv
Copy link
Collaborator

Any idea how easy/hard will it be to implement? Or will we consider it for UI Redesign?

It shouldn't be too difficult. We're currently using GtkScale to implement the seek bar, so gtk_scale_add_mark() can be used to add chapter marks. Doing that changes the shape of the slider though, so we need to override that behavior somehow.

@gnome-mpv gnome-mpv self-assigned this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants