Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting SCE to LOOM obs and var attribute names #59

Open
SimonDMurray opened this issue Aug 11, 2022 · 1 comment
Open

Converting SCE to LOOM obs and var attribute names #59

SimonDMurray opened this issue Aug 11, 2022 · 1 comment

Comments

@SimonDMurray
Copy link
Member

SimonDMurray commented Aug 11, 2022

Hi,
I was recently trying to convert an SCE object to loom and I noticed the sce2loom function contains the line:
colnames_attr = "obs_names", rownames_attr = "var_names"
which I changed to:
colnames_attr = "CellID", rownames_attr = "Gene"
in order to get my downstream analysis to work.

I was curious if there was a reason you did this as LOOM documentation suggests "CellID" and "Gene"?

Thanks in advance!
Simon

@nh3
Copy link
Collaborator

nh3 commented Sep 1, 2022

Sorry for the late reply. Thank you for bringing this to attention. It was an outdated decision/piece of code. Happy to change to "CellID" and "Gene" in the next release. A PR would be highly welcome. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants