Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: consolidate ErrByzantineCol/Row intos one ErrByzantineData #78

Closed
Wondertan opened this issue Apr 19, 2022 · 0 comments · Fixed by #80
Closed

api: consolidate ErrByzantineCol/Row intos one ErrByzantineData #78

Wondertan opened this issue Apr 19, 2022 · 0 comments · Fixed by #80
Assignees
@adlerjohn

Comments

@Wondertan
Copy link
Member

So that we handle row/cols branchlessly(without ifs to row/col). From what I observed, code that handles rows and cols can be unified into one code path within the lib itself and external users, e.g. celestia-node
@adlerjohn adlerjohn self-assigned this Apr 19, 2022
@adlerjohn adlerjohn moved this to TODO in Celestia Node Apr 19, 2022
@adlerjohn adlerjohn mentioned this issue Apr 25, 2022
Merged
Repository owner moved this from TODO to Done in Celestia Node Apr 26, 2022
@liamsi liamsi mentioned this issue Apr 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adlerjohn adlerjohn

Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify byz row and col errors. celestiaorg/rsmt2d
2 participants
@adlerjohn @Wondertan