Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(state/core_access): remove defaultSignerAccount and defaultSignerAddress in favor and use app.ClientTx instead #3515

Closed
vgonkivs opened this issue Jun 20, 2024 · 6 comments
Closed

improvement(state/core_access): remove defaultSignerAccount and defaultSignerAddress in favor and use app.ClientTx instead #3515

vgonkivs opened this issue Jun 20, 2024 · 6 comments
Labels
area:state Related to fetching state and state execution good first issue Good for newcomers

Comments

@vgonkivs
Copy link
Member

vgonkivs commented Jun 20, 2024 •
edited
Loading

We can get rid of these two fields inside core_access and ru-use clientTx. Since the node's version of the app contains a small bug in handling DefaultAccountAddress(), it should be done after celestiaorg/celestia-app#3597 is included in app release.

Lets also use only user.WithDefaultAccount(keyName) in SetupTxClient
@vgonkivs vgonkivs added good first issue Good for newcomers area:state Related to fetching state and state execution labels Jun 20, 2024
@MukulKolpe
Copy link

Hey @vgonkivs, can I work on this issue?

@vgonkivs
Copy link
Member Author

Hello, @MukulKolpe. These changes haven't been released yet. Also this issue is blocked by #3349

@vgonkivs
Copy link
Member Author

Hello @MukulKolpe. Do you still want to work on this issue?

@MukulKolpe
Copy link

Yes, I am still interested in working on this issue.

@vgonkivs
Copy link
Member Author

Awesome. Thank you so much. Do not hesitate to ask any questions.

@kobakaku kobakaku mentioned this issue Aug 12, 2024
Closed
@MukulKolpe MukulKolpe removed their assignment Jan 10, 2025
@vgonkivs
Copy link
Member Author

After adding a retry mechanism for creating a TxClient, this issue becomes not relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:state Related to fetching state and state execution good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(state): remove defaultSignerAccount and defaultSignerAddress method kobakaku/celestia-node
3 participants
@vgonkivs @MukulKolpe and others