Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipld: Extract IPLD plugin into separate repository #21

Closed
1 of 5 tasks
Wondertan opened this issue Aug 20, 2021 · 6 comments
Closed
1 of 5 tasks

ipld: Extract IPLD plugin into separate repository #21

Wondertan opened this issue Aug 20, 2021 · 6 comments
Assignees
Labels
area:ipld IPLD plugin area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Wondertan commented Aug 20, 2021

Goal

For ShareExchange and DASing to work we need to use IPLD implementation of NMT, which is currently located in Core. The Node needs to use it as well, so we need to extract the plugin with supporting functions into a separate repo to be used by both Core and Node repos.

Actions

@renaynay
Copy link
Member

@Wondertan can you make the first action item link to #111 ?

@liamsi
Copy link
Member

liamsi commented Apr 14, 2022

Are we still planning to move this into a separate repo? I think for now we are fine with this living in node (instead of core). Should we close this and revisit once a need arises?

@adlerjohn adlerjohn moved this to TODO in Celestia Node Apr 14, 2022
@renaynay renaynay changed the title Use NMT IPLD plugin ipld: Extract IPLD plugin into separate repository Apr 26, 2022
@renaynay renaynay added the area:ipld IPLD plugin label Apr 26, 2022
@renaynay
Copy link
Member

@liamsi post mainnet likely

@liamsi
Copy link
Member

liamsi commented Apr 27, 2022

ref: #656

I think we can close this for now. Feel free to re-open if needed.

@liamsi liamsi closed this as completed Apr 27, 2022
Repository owner moved this from TODO to Done in Celestia Node Apr 27, 2022
@Bidon15 Bidon15 reopened this Jul 12, 2022
Repository owner moved this from Done to In Progress in Celestia Node Jul 12, 2022
@Bidon15
Copy link
Member

Bidon15 commented Jul 12, 2022

Grooming 12/07/2022:

  1. Moving to Post-Mainnet
  2. Extraction should be done after ipld: Consolidation with share #878

@Bidon15 Bidon15 moved this from In Progress to TODO in Celestia Node Jul 12, 2022
@Bidon15
Copy link
Member

Bidon15 commented Nov 1, 2022

Grooming 01/11/2022:

There is no reason to follow-up/track this issue due to a different approach and core/app won't use it

@Bidon15 Bidon15 closed this as completed Nov 1, 2022
Repository owner moved this from TODO to Done in Celestia Node Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ipld IPLD plugin area:shares Shares and samples
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants