Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Providing from PutBlock #12

Closed
2 tasks
evan-forbes opened this issue Jun 22, 2021 · 1 comment
Closed
2 tasks

Decouple Providing from PutBlock #12

evan-forbes opened this issue Jun 22, 2021 · 1 comment

Comments

@evan-forbes
Copy link
Member

Summary

Move providing outside of the PutBlock function and into its own.

Details

Only the data availability header and access to the context routing IPFS api is needed in order to provide to the IPFS DHT, so it is possible to decouple providing from the PutBlock. This gives us the advantage of having more control over when we provide and when we do not. This has already been done in the PR that inspired this issue, celestiaorg/celestia-core#427, but should likely be decoupled from that PR into its own.

Action Items

  • create a new Provide function
  • remove providing from PutBlock

References

@liamsi
Copy link
Member

liamsi commented Aug 16, 2021

Falls outside of this repo. How and if the IPFS DHT will be used should be part of the discussion in #1

@liamsi liamsi closed this as completed Aug 16, 2021
@liamsi liamsi transferred this issue from celestiaorg/celestia-core Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants