From bc6a05b7340e31451cb7b8c4141431e5e0e3c3c3 Mon Sep 17 00:00:00 2001 From: Vlad Date: Fri, 4 Aug 2023 15:28:55 +0300 Subject: [PATCH] fix getAccessorTime incorrect meter --- share/eds/metrics.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/share/eds/metrics.go b/share/eds/metrics.go index 75965039f3..82adb246f1 100644 --- a/share/eds/metrics.go +++ b/share/eds/metrics.go @@ -43,6 +43,7 @@ type metrics struct { getTime metric.Float64Histogram hasTime metric.Float64Histogram listTime metric.Float64Histogram + getAccessorTime metric.Float64Histogram longOpTime metric.Float64Histogram gcTime metric.Float64Histogram @@ -97,6 +98,12 @@ func (s *Store) WithMetrics() error { return err } + getAccessorTime, err := meter.Float64Histogram("eds_store_get_accessor_time_histogram", + metric.WithDescription("eds store get accessor time histogram(s)")) + if err != nil { + return err + } + longOpTime, err := meter.Float64Histogram("eds_store_long_operation_time_histogram", metric.WithDescription("eds store long operation time histogram(s)")) if err != nil { @@ -118,6 +125,7 @@ func (s *Store) WithMetrics() error { getTime: getTime, hasTime: hasTime, listTime: listTime, + getAccessorTime: getAccessorTime, longOpTime: longOpTime, gcTime: gcTime, } @@ -253,7 +261,7 @@ func (m *metrics) observeGetAccessor(ctx context.Context, dur time.Duration, cac ctx = context.Background() } - m.listTime.Record(ctx, dur.Seconds(), metric.WithAttributes( + m.getAccessorTime.Record(ctx, dur.Seconds(), metric.WithAttributes( attribute.Bool(cachedKey, cached), attribute.Bool(failedKey, failed))) }