Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fixes typo causing the roots not be hashed #97

Merged
merged 1 commit into from
Nov 23, 2020
Merged

types: fixes typo causing the roots not be hashed #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG_PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ Friendly reminder, we have a [bug bounty program](https://hackerone.com/tendermi
- [statesync] \#5516 Check that all heights necessary to rebuild state for a snapshot exist before adding the snapshot to the pool. (@erikgrinaker)

### BUG FIXES

- [types] /#97 Fixes a typo that causes the row roots of the datasquare to be included in the DataAvailabilty header twice. (@evan-forbes)
2 changes: 1 addition & 1 deletion types/block.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func (dah *DataAvailabilityHeader) Hash() []byte {
for i, rowRoot := range dah.RowsRoots {
slices[i] = rowRoot.Bytes()
}
for i, colRoot := range dah.RowsRoots {
for i, colRoot := range dah.ColumnRoots {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch 🙈 a classic bug that would have been caught with some simple unit tests or a proper review!

Thanks a lot for this @evan-forbes!

slices[i+colsCount] = colRoot.Bytes()
}
// The single data root is computed using a simple binary merkle tree.
Expand Down