Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the generated mocks CI check #915

Closed
evan-forbes opened this issue Dec 15, 2022 · 1 comment
Closed

Remove the generated mocks CI check #915

evan-forbes opened this issue Dec 15, 2022 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@evan-forbes
Copy link
Member

    The crux is that v0.34.23 changes the `Peer` interface but in order to make it non-breaking, a new interface was introduced:
type EnvelopeSender interface {
	SendEnvelope(Envelope) bool
	TrySendEnvelope(Envelope) bool
}

and a few shim functions were added to support the old Peer which has Send and the new Peer which has SendEnvelope (NOTE: in v0.37 the interface is then broken).

I'm going to merge this now but either we:

  1. rollback the tests in tendermint/tendermint@bdedf2e#diff-845bad6985bed7731e25d658c3bfbc7f5639ebf2a739b8074fe9614ce71941bc that change Send to SendEnvelope
  2. Turn off the mockery checker
  3. Bring the change in v0.37 forward such that the Peer interface has SendEnvelope as well.

Originally posted by @cmwaters in #906 (comment)

@evan-forbes evan-forbes added the good first issue Good for newcomers label Dec 15, 2022
@cmwaters
Copy link
Contributor

Closing by #917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants