Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated TODO #1391

Closed
rootulp opened this issue Jun 13, 2024 · 1 comment
Closed

Remove outdated TODO #1391

rootulp opened this issue Jun 13, 2024 · 1 comment
Assignees
@rootulp

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jun 13, 2024

Context

celestia-core/state/execution.go

Lines 110 to 115 in fb9d656

// TODO(ismail): reaping the mempool has to happen in relation to a max
// allowed square size instead of (only) Gas / bytes
// maybe the mempool actually should track things separately
// meaning that CheckTx should already do the mapping:
// Tx -> Txs, Message
// https://github.com/tendermint/tendermint/issues/77

Problem

The link tendermint/tendermint#77 is incorrect, it should be #77. Given that issue is complete, I don't think this TODO should remain in the codebase.

Proposal

Remove the TODO
@rootulp rootulp self-assigned this Jun 13, 2024
@rootulp rootulp mentioned this issue Jun 13, 2024
Merged
rootulp added a commit that referenced this issue Jun 17, 2024
@rootulp
chore: remove outdated TODO (#1392)
cc8842f 
Closes #1391
@rootulp
Copy link
Collaborator Author

rootulp commented Jun 18, 2024

Closed by #1392

@rootulp rootulp closed this as completed Jun 18, 2024
rach-id pushed a commit that referenced this issue Nov 18, 2024
@rootulp @rach-id
chore: remove outdated TODO (#1392)
cf224fb 
Closes #1391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp