docs: hoist ADR status #1407
docs: hoist ADR status #1407
Conversation
rootulp
requested review from
liamsi,
adlerjohn,
MSevey and
evan-forbes
as code owners
|
|
||
| Accepted -> Does not affect the Celestia Core Specification | ||
|
|
||
| Optimization 1 & 2 **Declined** as it is currently not worth it to introduce extra complexity for reducing the PFB proof size by 512-1024 bytes. |
There was a problem hiding this comment.
Bit messy imo to have half-accepted ADRs..
|
Left some general comments about inconsistent usage of status message but it doesn't have to block this PR which just moves the status field up.
Yes but it's not urgent.
I think all things called ADR in the org should follow the same template. If they follow a radically different template, they should be called something other than an ADR, to avoid confusion. cc @MSevey @liamsi |
Since the ADRs are files, I don't know if any GitHub features for the templates, like issue templates for example. The simplest thing would be to just have an adr_template.md file in each repo. It's mostly a one time cost to make the template in all the repos that need it. |
|
We already have an ADR template per repo so changes to the ADR template (like the one in this PR) would need to be re-applied across all repos. I was proposing a celestiaorg wide repo that contains one ADR template. It may also be useful for things like linter rules where we establish an org wide standard. |
|
We should maybe include authors / Co-authors in ADRs so they can be pinged in future references |
|
org wide template would be cool |
Addresses #1161 (comment)
Questions