Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make S2i steps parameters configurable by env variables. #35

Open
jfdenise opened this issue Jul 2, 2021 · 3 comments
Open

Make S2i steps parameters configurable by env variables. #35

jfdenise opened this issue Jul 2, 2021 · 3 comments

Comments

@jfdenise
Copy link
Contributor

jfdenise commented Jul 2, 2021

We are in a case where tests scenarii could be shared by multiple images if the s2i build step was configurable (eg: build src repo, tag, context-dir, ...).
A user could write something like:
Given s2i build $BEHAVE_TEST_REPO from $BEHAVE_TEST_APP1 using $BEHAVE_TEST_REPO_TAG

The various env variables would have to be set in the context of the test execution.

We could consider that, if a parameter starts with '$', it is an env variable to be resolved. If no such env variable exists, then the parameter is passed as is to the s2i command.

@jfdenise
Copy link
Contributor Author

jfdenise commented Jul 2, 2021

@goldmann @luck3y we have a use-case for it in the context of wildfly/jboss images. If you are ok with the idea, I could contribute the feature. I have a POC of it locally.

@luck3y
Copy link
Contributor

luck3y commented Jul 22, 2021

@jfdenise This sounds like a good idea to me, as long as @goldmann doesn't have any objections I think you should do it.

@goldmann
Copy link
Contributor

Wouldn't this make the test not deterministic? If you provide different parameter/env (accidentally or not), then you would end up with results that cannot be really trusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants