Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IJsDialogHandler.OnJSBeforeUnload to OnBeforeUnloadDialog #2523

Closed
2 tasks done
amaitland opened this issue Sep 25, 2018 · 0 comments
Closed
2 tasks done

Rename IJsDialogHandler.OnJSBeforeUnload to OnBeforeUnloadDialog #2523

amaitland opened this issue Sep 25, 2018 · 0 comments
Labels
breaking-change
Milestone
69.0.0

Comments

@amaitland
Copy link
Member

amaitland commented Sep 25, 2018 •
edited
Loading

The CefJSDialogHandler::OnBeforeUnloadDialog currently maps to IJsDialogHandler.OnJSBeforeUnload, this is inconsistent with the CEF API and will be renamed to IJsDialogHandler.OnBeforeUnloadDialog.

  • Rename method
  • Fix API DOC, doesn't match upstream comments
@amaitland amaitland added this to the 69.0.0 milestone Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
69.0.0
Development

No branches or pull requests
1 participant
@amaitland