We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When serializing an instance of BillingInfo, a RangeError will be encountered due to the following code: https://github.com/ceejbot/recurring/blob/master/lib/models/billing-info.js#L53
The class is creating a property getter that points to itself.
An error similar to the following is produced:
"err": { "message": "Maximum call stack size exceeded", "name": "RangeError", "stack": "RangeError: Maximum call stack size exceeded\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:52:43)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)\n at BillingInfo.__defineGetter__ [as account_code] (/var/task/node_modules/recurring/lib/models/billing-info.js:53:19)" }
Looks like
this.__defineGetter__('account_code', () => { return this.account_code })
Should be
this.__defineGetter__('account_code', () => { return this.properties.account_code })
Happy to send a PR if this repo is still active.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
When serializing an instance of BillingInfo, a RangeError will be encountered due to the following code:
https://github.com/ceejbot/recurring/blob/master/lib/models/billing-info.js#L53
The class is creating a property getter that points to itself.
An error similar to the following is produced:
Looks like
Should be
Happy to send a PR if this repo is still active.
The text was updated successfully, but these errors were encountered: