Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function rne_park_forward issue #34

Open
zhengf0509 opened this issue Dec 13, 2020 · 1 comment
Open

function rne_park_forward issue #34

zhengf0509 opened this issue Dec 13, 2020 · 1 comment

Comments

@zhengf0509
Copy link

In this function,
dV[i] = ifunc(geom.S[i] * rbtdef.ddq[i]) +
ifunc(Adj(geom.Tdh_inv[i], dV[i - 1])) +
ifunc(adj(ifunc(Adj(geom.Tdh_inv[i], V[i - 1])),
ifunc(geom.S[i] * rbtdef.dq[i])))

but I think
dV[i] = ifunc(geom.S[i] * rbtdef.ddq[i]) +
ifunc(Adj(geom.Tdh_inv[i], dV[i - 1])) +
ifunc(adj(ifunc(Adj(geom.Tdh_inv[i], V[i - 1]) +ifunc(geom.S[i] * rbtdef.dq[i])),
ifunc(geom.S[i] * rbtdef.dq[i])))

beccause the bold font content should be the adjoint matrix of twist V[i]。

@cdsousa
Copy link
Owner

cdsousa commented Dec 27, 2020

Please, make a Pull Request. It will be easier to review the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants