"Language" is hardcoded in Top Banner component

[timarney]

Unable to set the Language link in the top banner.

<Container
          flex="1 1 auto"
          mr={3}
          css={css`
            text-align: right;
          `}
        />
        <FooterLink href="#" color="white" mr={3}>
          Language
        </FooterLink>
      </Container>

[evadb]

👍 good catch! Tbh I pulled this out quickly from RCMP project which had a bunch of language stuff hard coded in by doing the language query.

What would you think of a solution where the language is passed as a prop? Although there would still need to be some logic passed in somehow to do language switching 🤔

[timarney]

I think a prop makes the most sense for a quick fix and to move things forward.

Ultimately I think the end user is going to need more control overall.

i.e to control a language desktop vs mobile + when more languages possibly a dropdown menu. Accepting a child prop etc...

Kent C Dodds has some interesting patterns of Egghead for building components that allow a lot of flexibility .... that's a much larger discussion for later.