Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VS Code remote extensions #1315

Open
3 tasks
nhooyr opened this issue Jan 29, 2020 · 55 comments
Open
3 tasks

Implement VS Code remote extensions #1315

nhooyr opened this issue Jan 29, 2020 · 55 comments
Labels
extension The issue needs to be fixed in the extension feature New user visible feature

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Jan 29, 2020

  • Container
  • SSH
  • Tunnels

Related #1032

@nhooyr nhooyr added the enhancement Some improvement that isn't a feature label Jan 29, 2020
@lukasmasuch
Copy link

In case this issue is about fixing the remote extensions to work with code-server, this related issue can be closed: #892. I would really like to see the SSH extension to work within code-server and would be happy to test it once there is any fix.

@sr229
Copy link
Contributor

sr229 commented Jan 29, 2020

@nhyoor if this interests you, there's a remote subfolder in the main vscode folder, wanna abuse reuse that?

@frank-dspeed
Copy link

frank-dspeed commented Feb 1, 2020

The remote extension does some checks as far as i know i decompiled it some times.

There is a validation shema i think we should first automate the decompile process and check that.

@nhooyr
Copy link
Contributor Author

nhooyr commented Feb 2, 2020

We cannot and will not decompile the extension, that is not valid per the license terms.

@Just-Insane
Copy link

Is there any further plan to implement these extensions?

@kirscheGIT
Copy link

Is there any further plan to implement these extensions?

Would also like to know, if you have still have plans to implement this. Thanks!

@code-asher
Copy link
Member

Nothing concrete at the moment.

@gyzerok
Copy link

gyzerok commented Jun 5, 2020

I currently have a need for Remote - SSH extension and unfortunately the official one doesn't work for me (which is unlikely to be solved upstream in the near future). So I am considering implementing it myself.

At least initially I would like to have it as simple as possible. Without any fancy terminal forwarding or something like that. Just make it so that the work with the filesystem and all the language servers are running on the vm and UI is running in the vscode. Similar two what we now have with code-server in the browser, but without browser version problems (such as cmd+w for example).

Would you have some pointers as to where to start investigating from inside vscode source?

@code-asher
Copy link
Member

At the moment I don't have a good idea of the full scope of what'll be required to make this work but it'll probably have to do with using and/or implementing the remote authority stuff.

There's a workspace.registerRemoteAuthorityResolver in the proposed API which might be a good starting point.

@JayDoubleu
Copy link

JayDoubleu commented Aug 17, 2020

building from vscode-1.48.0 branch + adding 9fb33dc , as well as adding ms-vscode-remote.remote-containers to extensionAllowedProposedApi.

This gets the remote extensions installed however it is still complaining with the error:

[ms-vscode-remote.remote-containers]: View container 'remote' requires 'enableProposedApi' turned on to be added to 'Remote'.

Tried executing via below.

code-server --enable-proposed-api ms-vscode-remote.remote-containers
code-server --enable-proposed-api=ms-vscode-remote.remote-containers

Is there any more direct way to add arguments to the vscode to execute ?
I'm not sure if the enable-proposed-api switch simply does nothing or there is something else to be enabled.

@code-asher
Copy link
Member

@JayDoubleu could you open a separate issue for the enable proposed API flag? It's possible we have a bug there.

I'm not confident the remote extensions will work in code-server even if we resolve that though. Unfortunately I won't be able to test since it's against the terms of service to use them in anything other than VS Code. 😢

@nhooyr
Copy link
Contributor Author

nhooyr commented Aug 20, 2020

See #1779

@JayDoubleu
Copy link

JayDoubleu commented Aug 26, 2020

Just tested this with ms-vscode-remote.remote-containers-0.132.0.vsix
When clicking open in container it just disconnects and reloads.
[server] disconnected from client {"proxies":3}

I'm assuming there is no way to get ANY remote or codespaces working with code-server ?
I can see that it's already connecting to localhost as a remote

@code-asher
Copy link
Member

I haven't investigated (I don't think I can since legally we can't run the extension with code-server) so I can't be sure but yeah, I think it's possible that code-server technically being a remote already might be what's causing the incompatibility.

@code-asher
Copy link
Member

I'd be curious to know whether the remote extensions work in VS Code's own online offering, if anyone has given that a try. If they don't work then maybe they'll do some work to make it possible. If they do work then I think it's unlikely we'll be able to do anything about it.

@JayDoubleu
Copy link

The VSCode online AKA codespaces returns
Cannot install 'Remote - Containers' because this extension has defined that it cannot run on the remote server
when trying to install extension.

The codespace when opened already acts as a remote, and Microsoft allows for multiple of those.

The VS Code Remote - Containers extension allows you to clone a repository or open any folder mounted into (or already inside) a dev container and take advantage of VS Code's full development feature set. Visual Studio Codespaces and Codespaces in GitHub both use this same concept to quickly create customized, cloud-based development environments accessible from VS Code or the web.

It looks like it detects the devcontainer.json and automatically bootstraps into the environment as one would through remote container extension.

@code-asher
Copy link
Member

code-asher commented Aug 27, 2020

Ah, we disable the remote extension check and just let every extension attempt to run which explains why code-server doesn't display that error (otherwise extensions like vscode-icons won't run even though they work).

I suppose that means the extension is not meant to work by design, at least as it currently stands, and that probably won't change if they've already coded the functionality separately in codespaces. So in the end we're basically stuck just having to re-implement these extensions.

@JayDoubleu
Copy link

I see,
The ability to spin up multiple code-server codespaces* while using devcontainer.json as provisioner would be a very appreciated feature.
In theory one could create some sort of wrapper with just docker build + bind mounts however its all about the experience.

@nhooyr nhooyr added extension The issue needs to be fixed in the extension feature New user visible feature and removed enhancement Some improvement that isn't a feature labels Dec 7, 2020
@bryanculver
Copy link

✋ I would love to know who/how I can help. I've worked with TypeScript, Docker, and other tangentially related bits. Green behind the ears when it comes to contributing to this repo but I'm using code-server almost daily now from an iPad. Would love to leverage an almost inverse of most people's setups of remote extensions, where I have powerful machines running at home and would like to leverage them instead of massively scaling up my droplets.

@jsjoeio
Copy link
Contributor

jsjoeio commented May 26, 2021

@bryanculver love the enthusiasm and the willingness to help ❤️

I have not looked into this myself, but maybe @code-asher can give a pointer on to where to start?

@code-asher
Copy link
Member

code-asher commented May 26, 2021

I'm actually not sure how the remote extensions are implemented but they will need to do something like this:

  1. Connect to the remote (SSH, Docker, etc)
  2. Download code-server into the remote if necessary
  3. Start code-server in the remote if not already started
  4. Connect to code-server (not completely sure what this entails, might need to make modifications to code-server to support non-web connections)
  5. At this point things are quite fuzzy for me. Somehow the extensions provide file access (maybe through registerFileSystemProvider?) and extensions (no idea how this is done). It's possible the extensions use APIs that aren't documented.

@bryanculver
Copy link

The comments above are a goldmine. My old mentor's comedic relief quip "should be simple" is ringing in my head. Since they haven't published the extension with a permissive license nor the source code, a non-trivial complexity is necessary to implement this.

However seeing code-server is already being run as a server process, 🤞 this isn't that hard.

Would it be fair to say/assume that this will have to be it's own plugin (with maybe some enhanced APIs on the client side)? Trying to determine if I should fork this repo and start a new plugin project somewhere or start a new repo to build this out.

@sr229
Copy link
Contributor

sr229 commented May 27, 2021

The comments above are a goldmine. My old mentor's comedic relief quip "should be simple" is ringing in my head. Since they haven't published the extension with a permissive license nor the source code, a non-trivial complexity is necessary to implement this.

However seeing code-server is already being run as a server process, 🤞 this isn't that hard.

Would it be fair to say/assume that this will have to be it's own plugin (with maybe some enhanced APIs on the client side)? Trying to determine if I should fork this repo and start a new plugin project somewhere or start a new repo to build this out.

I was working on this under the calliope repo. I haven't gone around it for a while but I may when I have enough time. We can probably pool together and make this possible!

@bryanculver
Copy link

@sr229 Awesome! Please tell me how I can jump in to help. I've been trying to verify if the existing plugins leverage undocumented APIs to deliver some of the client side features at the moment.

@code-asher
Copy link
Member

Would it be fair to say/assume that this will have to be it's own plugin (with maybe some enhanced APIs on the client side)?

Yup, this would need to be a separate plugin. I think a separate repo will make the most sense for that.

There may be changes we have to make to code-server itself as well; in that case you'll need to fork this repo.

@sr229
Copy link
Contributor

sr229 commented May 28, 2021

@sr229 Awesome! Please tell me how I can jump in to help. I've been trying to verify if the existing plugins leverage undocumented APIs to deliver some of the client side features at the moment.

As far as I'm aware, they use the undocumented proposed APIs for remote. Apparently they are documented but no formal documentation exists outside the vscode.proposed.d.ts file.

@Lestt
Copy link

Lestt commented Jun 21, 2021

@sr229 I just noticed your message... as you tagged me in the edition mode, i got no notification. I ll show up asap on the Coder Slack and see if I can be useful.
Sorry again for the late reply.

@vegardhw
Copy link

So the idea here is to have code-server serve as the lightweight "local os", and from there ssh-remote to other systems? As in the overview image at the top here: https://code.visualstudio.com/docs/remote/remote-overview (local os -> remote os).

@code-asher
Copy link
Member

code-asher commented Jun 30, 2021 via email

@vegardhw
Copy link

vegardhw commented Jul 9, 2021

This sounds awesome! :) What is the expected timeline for a release...? :)

@code-asher
Copy link
Member

code-asher commented Jul 12, 2021 via email

@geiseri
Copy link
Contributor

geiseri commented Sep 19, 2021

Given the "legal issues" surrounding this I think it would be best to just implement something "compatible" with dev containers. Currently, I run code-server in a docker, so IMHO it would be easier to just have something that will build a docker env from that dev container and run code-server from there. Then the current proxy code used for exposing web development can just forward to that instance. Thus far I have found the remote container development "clunky" at best and running code-server inside of a docker has proven a more usable experience. There is also the issue that code-server should have its own value beyond being a drop-in for MS technology that is easily replaceable. So far code-server can be instigated via ssh, it can run perfectly inside of docker. Just my 2c as someone who uses both remote VS code and code-server.

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 20, 2021

^cc @bpmct @kylecarbs

@jarodium
Copy link

Maybe I am misintepreting the intent of the original issue, but is this issue about to use extensions on a remote location? If so, why not mount a ssh folder on the local/host machine and then run code-server to use that particular folder?

like this:
" --extensions-dir="DRIVELETTER:\VSCODE\extensions""
" --user-data-dir="DRIVELETTER:\VSCODE\settings""

I have a use case in which I will need this kind of setup. I want to run code-server inside several containers, in which I want a workspace to be available, but I would like to pre-install extensions when I bootup a container.

I understand that this setup will raise a great number of issues, but for me and my team would be great, since we always use the same extensions to work and has the bonus of adding another person to the team and start him/her up without going through environment setups.

@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 25, 2022

I have a use case in which I will need this kind of setup. I want to run code-server inside several containers, in which I want a workspace to be available, but I would like to pre-install extensions when I bootup a container.

This basically sounds like your own version of Coder! We have many teams who do this. The most common way I've seen is installing the extension as part of the Dockerfile so that it's available when your teammates create a workspace (i.e. access code-server):

https://coder.com/docs/coder/latest/workspaces/vs-code-extensions#adding-extensions-to-custom-images

@spwoodcock
Copy link

spwoodcock commented Mar 25, 2022

Though it would be nice to have the official remote extensions working, I can't see it happening anytime soon.

I have been using code-server for a few years now deployed inside a container (Docker & Kubernetes) & recently got remote debugging working inside Docker containers for a FastAPI app. (sidenote: Docker in Docker is messy. I currently bind mount docker.sock for local development, but I'm sure using a remote TCP host via DOCKER_HOST would work too.)

For anyone looking at remote debugging, this approach should work for any language that supports a remote debug package (e.g. Python, Node...). I currently use the debugpy package in Python.

In the root of your repo, add launch.json and tasks.json into the .vscode directory.

launch.json:

{
  "configurations": [
    {
      "name": "Python - Remote Attach",
      "type": "python",
      "preLaunchTask": "docker-compose: cycle",
      "request": "attach",
      "host": "NAME_OF_YOUR_DOCKER_CONTAINER",
      "port": 5678,
      "pathMappings": [
        {
          "localRoot": "${workspaceFolder}",
          "remoteRoot": "/opt/app"
        }
      ],
      "justMyCode": false,
    }
  ]
}

tasks.json (note: you could use a dockerCompose type task, but this doesn't support V2):

{
  "version": "2.0.0",
  "tasks": [
    {
      "label": "docker-compose: cycle",
      "type": "shell",
      "command": "docker compose down && docker compose up -d api --no-build",
    }
  ],
}

Relevant part of Dockerfile to make this work:

...
...
ENTRYPOINT ["uvicorn", "main:app", "--host", "0.0.0.0", "--port", "8000"]
USER appuser


FROM runtime as dev
RUN pip install debugpy
ENTRYPOINT ["python", "-m", "debugpy", "--wait-for-client", "--listen", \
            "0.0.0.0:5678", "-m", "uvicorn", "main:app", "--host", \
            "0.0.0.0", "--port", "8000"]
CMD ["--reload", "--log-level", "error", "--no-access-log"]


FROM runtime as prod
CMD ["--workers", "1", "--log-level", "error", "--no-access-log"]

@archef2000
Copy link

Hello sorry if i ask, but is there currently a way to use the projects of code-server with the desktop app?

@Enissay
Copy link

Enissay commented Jun 30, 2024

Any update on this please ?

Or at least if someone could share a workaround to access remote files from ssh through code-server on docker ?

@code-asher
Copy link
Member

We have no plans on working on this, but there is an open source version here: https://github.com/jeanp413/open-remote-ssh

I have not tried it, but maybe it can be made to work with code-server.

@code-asher
Copy link
Member

code-asher commented Jul 1, 2024

Or this extension might work: https://open-vsx.org/extension/Kelvin/vscode-sshfs

@Enissay
Copy link

Enissay commented Jul 1, 2024

Or this extension might work: https://open-vsx.org/extension/Kelvin/vscode-sshfs

It doesnt sadly, I tried 2 more from the extension list and none worked, they just show empty pages...

We have no plans on working on this, but there is an open source version here: https://github.com/jeanp413/open-remote-ssh

I have not tried it, but maybe it can be made to work with code-server.

Thank you, I will try to figure out how to install it and revert back

@code-asher code-asher mentioned this issue Jul 23, 2024
@MobCode100
Copy link

For a workaround, use the extension SSH FS as @code-asher mentioned. It works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension The issue needs to be fixed in the extension feature New user visible feature
Projects
None yet
Development

No branches or pull requests