-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial implementation of a StackSet L2 construct #2
Conversation
accounts: ['11111111111'], | ||
}), | ||
template: StackSetTemplate.fromStackSetStack(stackSetStack), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some related questions:
- Can multiple
StackSetStacks
be defined in the same scope? - Would it make sense to require that a
StackSet
be defined in the scope of aStackSetStack
? - (if the answer to the above is "no") Is there a way to infer which
StackSetStack
is the correct one, instead of forcing the user to pass atemplate
property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can multiple StackSetStacks be defined in the same scope?
Would it make sense to require that a StackSet be defined in the scope of a StackSetStack?
(if the answer to the above is "no") Is there a way to infer which StackSetStack is the correct one, instead of forcing the user to pass a template property?
It's a little confusing, but I modeled this after the way Service Catalog works. The StackSet
construct is the L2 for the CfnStackSet
CloudFormation resource and it requires that you give it a CloudFormation Stack template. We can't just use a normal cdk.Stack
because there are some limitations to StackSet stack templates that we need to account for. Long term I also want to have other ways of providing a template
template: StackSetTemplate.fromStackSetStack(stackSetStack);
template: StackSetTemplate.fromAsset(asset);
template: StackSetTemplate.fromInline('');
etc.
Signed-off-by: github-actions <[email protected]>
See README.md
We don't have to publish this right away if we don't want to, but I have most of an L2 for StackSets that I want to get out there. Some things that we should do.
Fixes #