maxConcurrentCount not passed

[shellraiser]

Found that when building CDK with maxConcurrentCount set, the setting does not get passed to the template that gets created. It sets the maxConcurrentCount as null instead.

class ApNortheast1Setup extends StackSetStack {
  constructor(scope: Construct, id: string, props: AwsConfigStacksetProps) {
    super(scope, id);

    const testRole = new Role(this, `${props.stage.name}ApNortheast1Role`, {});
  }
}

export class ApNortheast1Stackset extends DeploymentStack {
  constructor(parent: Construct, name: string, props: ApNortheast1StacksetProps) {
    super(parent, name, {
      ...props,
    });

    const apNortheast1Setup = new ApNortheast1Setup(this, `${props.stage.name}ApNortheast1`, props);

    new StackSet(this, `${props.stage.name}ApNortheast1StackSet`, {
      stackSetName: 'test-stackset-ap-northeast-1',
      description: 'Stackset that deploys withing ap-northeast-1',
      template: StackSetTemplate.fromStackSetStack(apNortheast1Setup),
      target: StackSetTarget.fromOrganizationalUnits({
        regions: [props.env.region],
        organizationalUnits: [props.mainOuId],
      }),
      capabilities: [Capability.NAMED_IAM],
      managedExecution: true,
      deploymentType: DeploymentType.serviceManaged({
        delegatedAdmin: false,
        autoDeployEnabled: true,
        autoDeployRetainStacks: false,
      }),
      operationPreferences: {
        regionConcurrencyType: RegionConcurrencyType.PARALLEL,
        maxConcurrentCount: 1000, // this doesn't work
        failureTolerancePercentage: 100,
      },
    });
  }
}

Expected: MaxConccurentCount is set to 1000
Actual Result: MaxConccurentCount set to null

[bpal410]

It looks like neither maxConcurrentCount nor failureToleranceCount are actually being utilized from this interface. Only failureTolerancePercentage/maxConcurrentPercentage are used to synthesize the StackSet template

export interface OperationPreferences {
  readonly failureToleranceCount?: number;
  readonly failureTolerancePercentage?: number;
  readonly maxConcurrentCount?: number;
  readonly maxConcurrentPercentage?: number;
  readonly regionConcurrencyType?: RegionConcurrencyType;
  readonly regionOrder?: string[];
}

[moltar]

Confirmed this not to be working. For those looking for a workaround:

    const cfnStackSet = stackSet.node.defaultChild; // stackSet is the instance of the cdk-stacksets class
    assert(cfnStackSet instanceof CfnStackSet); // type narrow
    cfnStackSet.operationPreferences = {
      // now you have access to these options
    };