feat: optional construct metadata in charts #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iliapolo <[email protected]>
iliapolo
commented
Aug 30, 2022
iliapolo
commented
Aug 30, 2022
Signed-off-by: iliapolo <[email protected]>
Signed-off-by: iliapolo <[email protected]>
Signed-off-by: github-actions <[email protected]>
|
@Mergifyio update |
✅ Branch has been successfully updated |
Signed-off-by: iliapolo <[email protected]>
Signed-off-by: github-actions <[email protected]>
|
@vinayak-kukreja I switched the implementation to write a Instead, we write a new file for the CLI to optionally consume. Let me know what you think, if you don't have any blocking comments, please approve and add a |
|
This looks really nice. 🚀 |
vinayak-kukreja
approved these changes
Sep 28, 2022
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
iliapolo
added a commit
that referenced
this pull request
Sep 28, 2022
Resolves #688 (cherry picked from commit 4b71d6c) Signed-off-by: Eli Polonsky <[email protected]> # Conflicts: # test/chart.test.ts
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
iliapolo
added a commit
that referenced
this pull request
Sep 28, 2022
* feat: optional construct metadata in charts (#721) Resolves #688 (cherry picked from commit 4b71d6c) Signed-off-by: Eli Polonsky <[email protected]> # Conflicts: # test/chart.test.ts * use Node.of instead of .node Signed-off-by: iliapolo <[email protected]> Signed-off-by: iliapolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #688