Job api to create jobs inside a folder

[Dhivyaa21]

Currently, the job Api to create a job is as follows

jenkins-rest/src/main/java/com/cdancy/jenkins/rest/features/JobsApi.java

Lines 73 to 82 in e176247

	@Named("jobs:create")
	@Path("/createItem")
	@Fallback(JenkinsFallbacks.RequestStatusOnError.class)
	@ResponseParser(RequestStatusParser.class)
	@Produces(MediaType.APPLICATION_XML)
	@Consumes(MediaType.WILDCARD)
	@Payload("{configXML}")
	@POST
	RequestStatus create(@QueryParam("name") String jobName,
	@PayloadParam(value = "configXML") String configXML);

This API creates a job in jenkins root folder but not inside a folder.

Perhaps, we can add another API to with a pathparam like @Path("{pathToJob}/createItem") to support the creation of jobs inside a folder.

[cdancy]

@Dhivyaa21 that sounds like a great idea. Maybe something like createWithPath(...) would do? Care to send in a PR?

@martinda you've been working in this space recently and may have some thoughts one way or another.

[Dhivyaa21]

@cdancy Sure. I can send you a PR.

[cdancy]

@Dhivyaa21 check out this PR and give things a go locally and let me know how you fare. We amend the existing create method to take an optional parameter which, if not null, gets injected into the path. This requires some knowledge of jclouds which is why I went ahead and put the initial impl in place. Feel free to build on top of it as needed. Some live/integ tests will need to be coded as well.

#11

[Dhivyaa21]

@cdancy This looks good. I am adding tests to this change. Meanwhile, a quick question. Do you think its a good idea to use this OPTIONAL_FOLDER_PATH_PARAM for all the job APIs? i am not sure if the other job APIs were designed to access jobs in a folder.

Right now we squeeze in the path to job in the {name} path parameter of other APIs. It works fine. It was just the create API that did not have a way to create the job in a folder. Hence, I created this issue.

Example -
Say I want to disable a job in the following path

"/job/folder/job/testJob"

Disable job api is

jenkins-rest/src/main/java/com/cdancy/jenkins/rest/features/JobsApi.java

Lines 131 to 136 in e176247

	@Named("jobs:disable")
	@Path("/job/{name}/disable")
	@Fallback(Fallbacks.FalseOnNotFoundOr404.class)
	@Consumes(MediaType.TEXT_HTML)
	@POST
	boolean disable(@PathParam("name") String jobName);

To disable the job , I'll have to call api().disable("folder/job/testJob") and not api().disable("testJob").

[cdancy]

@Dhivyaa21 I would say that any endpoint that can take an optional folder parameter you can put together a PR to wire all of them up. As there are a few please put each endpoint change into its own commit for easier viewing/reviewing on my end.

[martinda]

Great idea. I need this too. Thanks @Dhivyaa21 and @cdancy

[cdancy]

Functionality merged per #20