Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTC testnet4 support #249

Closed
jlopp opened this issue May 12, 2024 · 12 comments · Fixed by #255
Closed

BTC testnet4 support #249

jlopp opened this issue May 12, 2024 · 12 comments · Fixed by #255
Labels
BTC Related to Bitcoin BTC & Bitcoin Core enhancement New feature or request

Comments

@jlopp
Copy link

jlopp commented May 12, 2024

FYI testnet3 is being deprecated; you can find the parameters for testnet4 here: bitcoin/bitcoin#29775

@cculianu
Copy link
Owner

Ah thanks for the heads-up. Yeah we in BCH also deprecated our testnet3 and are onto testnet4. Good to see the BTC people are doing similar. I'll look at their changes and add BTC testnet4 soon, if they didn't do anything crazy ...

@cculianu cculianu added enhancement New feature or request BTC Related to Bitcoin BTC & Bitcoin Core labels May 13, 2024
@cculianu
Copy link
Owner

Oh ok I just noticed they haven't merged this yet but it looks essentially very compatible with existing testnet3, so it should be no problem to add support for this to Fulcrum. I will do so as soon as they merge this and/or plan a release containing it.

Thanks again for the heads-up. I will leave this issue open to remind myself to indeed add this to Fulcrum.

@jlopp
Copy link
Author

jlopp commented May 13, 2024

Yeah it's not finalized yet but I think it's pretty close.

@cculianu
Copy link
Owner

Sounds good I’m traveling now but I’ll add support once I get back and have it ready for once they merge. Good stuff again thanks for the heads up!

@ast261
Copy link

ast261 commented Aug 7, 2024

"I will do so as soon as they merge this"

It's done.

@twofaktor
Copy link

twofaktor commented Aug 8, 2024

Testnet4 on Fulcrum has been working for almost a month for me using the 1.11.0 version code:

imagen

And this config:

imagen

--> No code modifications are needed <--

@cculianu
Copy link
Owner

cculianu commented Aug 8, 2024

Oh yeah sorry I forgot to announce it -- I indeed added support for it! I guess I can close this issue now.

@cculianu cculianu closed this as completed Aug 8, 2024
@twofaktor
Copy link

Oh yeah sorry I forgot to announce it -- I indeed added support for it! I guess I can close this issue now.

4 years ago 😁:

#50

@cculianu
Copy link
Owner

cculianu commented Aug 8, 2024

Oh no that was for BCH (we did test4 on BCH 4 years ago back in COVID times). Hmm. Actually I realized that if you have peering=true it will fail right now on BTC because there is no server seed list for BTC test4. I need to implement that ASAP. I'm re-opening this issue.

@cculianu
Copy link
Owner

cculianu commented Aug 8, 2024

Ok, peering support has been added, so peering=true should work now on BTC testnet4. There is currently only 1 known Electrum server for testnet4, my own -- at blackie.c3-soft.com ssl port 57010, which has been compiled-in as the "seeding" node for peering.

@cculianu
Copy link
Owner

cculianu commented Aug 8, 2024

Let me know if you guys need a new release.. I figure there's no rush since Core hasn't released a binary with testnet4 yet, Electrum doesn't yet support it, etc... so i figured anybody interested can build Fulcrum from source now.. but let me know if you really really really want a release now that has this...

@twofaktor
Copy link

twofaktor commented Aug 13, 2024

if you really really really want a release now that has this...

It is not necessary at least for me, I can wait for the next Bitcoin Core release. Thanks for your implication 🙏

BTW: Testnet4 was recently merged!! -> bitcoin/bitcoin#29775 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTC Related to Bitcoin BTC & Bitcoin Core enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants