Upgrade actions/download-artifact to v4; Explicitly Check PEP 440 Compliance; Fix Workflows, Makefiles, and Boost Usage #340
+41
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. upgrade actions/upload-artifact; 2. include macos-aarch64 in compile binaries; 3. exclude macos, linux-aarch from pypi-build; 4. update yum repo files as a temp fix for Mirrorlist end-of-life; 5. change of job name in compile binaries
to find boost installed by apt-get (Linux) and homebrew (intel, Apple Silicon); 2. for newer boost versions: replace boost/filesystem/*.hpp by boost/filesystem.hpp in source; 3. explictly check for PEP 440 compliance of version: include packaging as build dependency, only return compliant version from setup.py
rwxayheee
changed the title
|
Amazing, thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not urgent to merge. The PR is intended to provide a temporary solution for current issues with Git Actions and maybe serve as a starting point for future updates.
This PR will allow itself to pass all checks triggered by PR, generating wheel files for Linux x86_64 (wheels), source dist (sdist), and compiled binaries for Linux x86_64/aarch64, MacOS x86_64/aarch64, and Windows as artifacts.