From e6820fe946ebf13cce6a43d3704fea0312ec1ed1 Mon Sep 17 00:00:00 2001
From: Mia <mia.tosi@cern.ch>
Date: Wed, 8 Oct 2014 14:04:06 +0200
Subject: [PATCH 1/3] add fillDescription method

---
 .../src/SiStripFEDDataCheck.cc                | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc b/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc
index c955918a10517..29b2507f0b261 100644
--- a/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc
+++ b/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc
@@ -21,6 +21,8 @@
 #include "FWCore/Framework/interface/EventSetup.h"
 #include "FWCore/Framework/interface/ESHandle.h"
 #include "FWCore/ParameterSet/interface/ParameterSet.h"
+#include "FWCore/ParameterSet/interface/ParameterSetDescription.h"
+#include "FWCore/ParameterSet/interface/ConfigurationDescriptions.h"
 #include "FWCore/Utilities/interface/InputTag.h"
 #include "FWCore/Utilities/interface/Exception.h"
 #include "FWCore/MessageLogger/interface/MessageLogger.h"
@@ -54,9 +56,12 @@ class SiStripFEDCheckPlugin : public DQMEDAnalyzer
  public:
   explicit SiStripFEDCheckPlugin(const edm::ParameterSet&);
   ~SiStripFEDCheckPlugin();
+  static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);
+
  private:
   virtual void analyze(const edm::Event&, const edm::EventSetup&) override;
   virtual void endRun();
+  
   void bookHistograms(DQMStore::IBooker &, edm::Run const &, edm::EventSetup const &) override;
 
   bool hasFatalError(const FEDRawData& fedData, unsigned int fedId) const;
@@ -411,6 +416,47 @@ void SiStripFEDCheckPlugin::updateHistograms()
   if (doPLOTfedFatalErrors_) fedFatalErrors_->getTH1()->SetEntries(entriesFatalErrors);
   if (doPLOTfedNonFatalErrors_) fedNonFatalErrors_->getTH1()->SetEntries(entriesNonFatalErrors);
 }
+void
+SiStripFEDCheckPlugin::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
+
+  edm::ParameterSetDescription desc;
+
+  // Directory to book histograms in
+  desc.add<std::string>("DirName","SiStrip/FEDIntegrity/");
+  // Raw data collection
+  desc.add<edm::InputTag>("RawDataTag",edm::InputTag("source"));
+  // Number of events to cache info before updating histograms
+  // (set to zero to disable cache)
+  // HistogramUpdateFrequency = cms.untracked.uint32(0),
+  desc.addUntracked<unsigned int>("HistogramUpdateFrequency",1000);
+  // Print info about errors buffer dumps to LogInfo(SiStripFEDCheck)
+  desc.addUntracked<bool>("PrintDebugMessages",false);
+  desc.add<bool>("doPLOTfedsPresent",      true);
+  desc.add<bool>("doPLOTfedFatalErrors",   true);
+  desc.add<bool>("doPLOTfedNonFatalErrors",true);
+  desc.add<bool>("doPLOTnFEDinVsLS",       false);
+  desc.add<bool>("doPLOTnFEDinWdataVsLS",  false);
+  // Write the DQM store to a file (DQMStore.root) at the end of the run
+  desc.addUntracked<bool>("WriteDQMStore",false);
+  // Use to disable all payload (non-fatal) checks
+  desc.addUntracked<bool>("DoPayloadChecks",true);
+  // Use to disable check on channel lengths
+  desc.addUntracked<bool>("CheckChannelLengths",true);
+  // Use to disable check on channel packet codes
+  desc.addUntracked<bool>("CheckChannelPacketCodes",true);
+  // Use to disable check on FE unit lengths in full debug header
+  desc.addUntracked<bool>("CheckFELengths",true);
+  // Use to disable check on channel status bits
+  desc.addUntracked<bool>("CheckChannelStatus",true);
+  desc.add<unsigned int>("LSBin",5000);
+  desc.add<double>      ("LSMin",   0.5);
+  desc.add<double>      ("LSMax",5000.5);  
+
+  descriptions.addDefault(desc);
+
+
+}
+
 
 //
 // Define as a plug-in

From 4e5e42238048a8f57f6b1482d6ff52072518ac6f Mon Sep 17 00:00:00 2001
From: Mia <mia.tosi@cern.ch>
Date: Wed, 8 Oct 2014 15:39:14 +0200
Subject: [PATCH 2/3] fix DirName as untracked also in fillDescription

---
 DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc b/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc
index 29b2507f0b261..dd414d226d60e 100644
--- a/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc
+++ b/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc
@@ -422,7 +422,7 @@ SiStripFEDCheckPlugin::fillDescriptions(edm::ConfigurationDescriptions& descript
   edm::ParameterSetDescription desc;
 
   // Directory to book histograms in
-  desc.add<std::string>("DirName","SiStrip/FEDIntegrity/");
+  desc.addUntracked<std::string>("DirName","SiStrip/FEDIntegrity/");
   // Raw data collection
   desc.add<edm::InputTag>("RawDataTag",edm::InputTag("source"));
   // Number of events to cache info before updating histograms

From 0b36149086a50a0863d5047b28741bc27bac90de Mon Sep 17 00:00:00 2001
From: Mia <mia.tosi@cern.ch>
Date: Wed, 8 Oct 2014 17:42:26 +0200
Subject: [PATCH 3/3] fix also LSBin

---
 DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc b/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc
index dd414d226d60e..1086929f99df8 100644
--- a/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc
+++ b/DQM/SiStripMonitorHardware/src/SiStripFEDDataCheck.cc
@@ -448,7 +448,7 @@ SiStripFEDCheckPlugin::fillDescriptions(edm::ConfigurationDescriptions& descript
   desc.addUntracked<bool>("CheckFELengths",true);
   // Use to disable check on channel status bits
   desc.addUntracked<bool>("CheckChannelStatus",true);
-  desc.add<unsigned int>("LSBin",5000);
+  desc.add<int>         ("LSBin",5000);
   desc.add<double>      ("LSMin",   0.5);
   desc.add<double>      ("LSMax",5000.5);