Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app is rejected from the app store #9

Closed
Daavidaviid opened this issue Jun 22, 2020 · 3 comments
Closed

The app is rejected from the app store #9

Daavidaviid opened this issue Jun 22, 2020 · 3 comments

Comments

@Daavidaviid
Copy link

Daavidaviid commented Jun 22, 2020

Hi,

I was playing with this library and I realized that the app is rejected by App Connect because the file build-c-libraries.sh from QuietModemKit is not signed.

I get a message like this :

Invalid Signature. Code object is not signed at all

Do you have any idea how to solve this issue ?

@cawfree
Copy link
Owner

cawfree commented Jun 22, 2020

Sorry you're experiencing this issue.

There doesn't seem to be much online regarding this kind of error, I've not seen it before.

My immediate thought is that this is an upstream issue, so it might be worth recreating the ticket under QuietModem.

This question on StackOverflow seems to insist that the .sh resource is the problem. This won't be called at runtime, but seems to be getting packaged.

Can you try deleting the file or removing it from your project's path?

@Daavidaviid
Copy link
Author

I solved this issue by removing the .sh file from the archive manually following this guide :
https://skillz.zendesk.com/hc/en-us/articles/204255859-iOS-App-signing-issues-with-postprocess-sh-script-in-Skillz-SDK-Bundle

@Daavidaviid
Copy link
Author

I was able to resolve this with fastlane using this custom action right before uploading to store :

remove_quiet_sh_file.rb

module Fastlane
  module Actions
    module SharedValues
      REMOVE_QUIET_SH_FILE_CUSTOM_VALUE = :REMOVE_QUIET_SH_FILE_CUSTOM_VALUE
    end

    class RemoveQuietShFileAction < Action
      def self.run(params)
        # fastlane will take care of reading in the parameter and fetching the environment variable:

        path = Actions.lane_context[SharedValues::XCODEBUILD_ARCHIVE]
        pathToFile = "Products/Applications/MyApp.app/Frameworks/QuietModemKit.framework/build-c-libraries.sh"

        # RM /Users/LePatron/Library/Developer/Xcode/Archives/2020-08-13/MyApp 2020-08-13 13.35.01.xcarchive/Products/Applications/MyApp.app/Frameworks/QuietModemKit.framework
        sh "rm -rf #{path}/#{pathToFile}"
      end

      #####################################################
      # @!group Documentation
      #####################################################

      def self.description
        "A short description with <= 80 characters of what this action does"
      end

      def self.details
        # Optional:
        # this is your chance to provide a more detailed description of this action
        "You can use this action to do cool things..."
      end

      def self.available_options
        # Define all options your action supports.

        # Below a few examples
        [
        ]
      end

      def self.output
        # Define the shared values you are going to provide
        # Example
        [
          ['REMOVE_QUIET_SH_FILE_CUSTOM_VALUE', 'A description of what this value contains']
        ]
      end

      def self.return_value
        # If your method provides a return value, you can describe here what it does
      end

      def self.authors
        # So no one will ever forget your contribution to fastlane :) You are awesome btw!
        ["Your GitHub/Twitter Name"]
      end

      def self.is_supported?(platform)
        # you can do things like
        #
        #  true
        #
        #  platform == :ios
        #
        #  [:ios, :mac].include?(platform)
        #

        platform == :ios
      end
    end
  end
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants