Main package should be compiled for node env

[quolpr]

I had an issue with the axios library when I was using axios in the main package, the code was resolving to the XHR adapter. It was happening due to this field in package.json of axios:

  "browser": {
    "./lib/adapters/http.js": "./lib/adapters/xhr.js"
  },

It means that for browser env ./lib/adapters/http.js file should be replaced with ./lib/adapters/xhr.js, but main package is running under node environment, and it was causing the error. Here is the more detailed issue vitejs/vite#6382 .

So, I fixed it with ssr: true in the build section of config.vite.js. What do you think about this? I can provide PR if you want 🙂

[quolpr]

Oops, the electron app will not work after compilation when ssr: true is provided; it fails to resolve dependencies(cause ssr: true doesn't bundle all deps to one file). So I am not sure how we could fix it 🤔 But we definitely need to let vite know that it is running in node env for the main package

[quolpr]

Also related issue vitejs/vite#4405

[cawa-93]

Hmmm...
Try add axios to external packages. That axios should resolve in runtime in electron environment

[quolpr]

Wow, thanks for the fast response, I will check 🙂 Also related axios/axios#456

[quolpr]

@cawa-93 this error happens when I running the compiled version

The yarn watch works like a charm

[quolpr]

Btw I am getting the same error for ssr: true for compiled version, while yarn watch works correctly

[cawa-93]

🤔 I just tried run compilation with ssr: true and doesn't saw problems

[cawa-93]

It seems you can import axios from relative path:

import axios from '../../../node_modules/axios';

That force Vite does't resolve browser mapping and resolve only as node. I'm not sure how safe it is 🤷‍♂️

[quolpr]

Oops, I used yarn workspaces, and that what the reason why some node packages were not loaded. Btw, I still think that the main package should use ssr: true, cause I suppose you will fail to use any native package(that uses gyp). As I understand later Vite will introduce this flag:

{
  resolve : {
    environment: 'node'
  }
}

[cawa-93]

Btw, I still think that the main package should use ssr: true,

You may be right. But I need more tests and research for that change

[cawa-93]

It seems build in ssr: true works fine for main and preload. But I can't dare use it because SSR support is still experimental.

[cawa-93]

Should be resolve in d002d6f