Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whiskers): use block context in darklight helper #144

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

backwardspy
Copy link
Member

template:

{{#each flavors}}
{{flavorName}} {{isLight}} {{darklight "night" "day"}}
{{/each}}

output before fix:

Latte true night
Frappé false night
Macchiato false night
Mocha false night

output after fix:

Latte true day
Frappé false night
Macchiato false night
Mocha false night

@backwardspy backwardspy added bug Something isn't working whiskers Issues relating to whiskers labels Mar 5, 2024
@backwardspy backwardspy requested a review from sgoudham March 5, 2024 22:19
@backwardspy backwardspy self-assigned this Mar 5, 2024
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned via VC, this is a workaround that gets the job done.

I'd imagine we'll want to rethink the architecture of whiskers and/or potentially move to a different rendering engine to try and fit our usecase(s) better.

Thanks!

@sgoudham sgoudham merged commit 486a747 into main Mar 5, 2024
3 checks passed
@sgoudham sgoudham deleted the fix/singlefile-darklight branch March 5, 2024 22:38
@github-actions github-actions bot mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working whiskers Issues relating to whiskers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants