Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dap-ui): add colors for *NC hlgroups of UI controls #783

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

fnune
Copy link
Contributor

@fnune fnune commented Oct 20, 2024

nvim-dap-ui has highlight groups for all its buttons: DapUIPlayPause, DapUIStepOver, etc. But it also has *NC versions of those highlights. I assume NC stands for non-current or "no cursor".

nvim-dap-ui defaults to linking those to their non-*NC versions but I assume it happens too early and Catppuccin does not pick that up. This PR simply duplicates the highlight groups to include *NC versions.

See https://github.com/rcarriga/nvim-dap-ui/blob/ffa89839f97bad360e78428d5c740fdad9a0ff02/lua/dapui/config/highlights.lua#L75-L96

Before

Screenshot_20241020_111017
Screenshot_20241020_110955

After

Screenshot_20241020_110436
Screenshot_20241020_110432

`nvim-dap-ui` has highlight groups for all its buttons:
`DapUIPlayPause`, `DapUIStepOver`, etc. But it also has `*NC` versions
of those highlights. I assume NC stands for non-current or "no cursor".

`nvim-dap-ui` defaults to linking those to their non-`*NC` versions but
I assume it happens too early and Catppuccin does not pick that up. This
PR simply duplicates the highlight groups to include `*NC` versions.

See https://github.com/rcarriga/nvim-dap-ui/blob/ffa89839f97bad360e78428d5c740fdad9a0ff02/lua/dapui/config/highlights.lua#L75-L96
@fnune fnune force-pushed the fnune/fix-dap-ui-nc-hls branch from b2b1518 to 29e42eb Compare October 23, 2024 20:53
@fnune fnune requested a review from sgoudham October 23, 2024 21:34
@sgoudham sgoudham merged commit d9ee9a3 into catppuccin:main Oct 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants