-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for OXY2DEV/markview.nvim
#764
Comments
OXY2DEV/Markview.nvim
OXY2DEV/markview.nvim
This plugin is amazing. +1 support for this |
I believe the current maintainers of this repository are not active at the moment so this would most likely need to be PR'd in. However, I'm unsure if this should be accepted as #740 was already merged before this issue was raised. https://github.com/MeanderingProgrammer/render-markdown.nvim seems to provide pretty much the same functionality and I'd imagine they can't both be enabled at the same time? |
markview.nvim is the king, better than render-markdown.nvim (although is a great plugin also) |
I looked through our existing integrations list and it does look like we are okay with allowing multiple plugins that overlap in functionality / featuresets so I'd be happy to accept a PR for it. I think it makes sense to set it false by default, however, I'm currently unsure of prior precendent on how we decide to set integrations to true or false. Maybe @vollowx or @mrtnvgr have some insights here? |
Unless there is any significant change in what currently is used and the integration, there is no need to set it to The plugin uses
But you guys are more smarter than me, so I will leave it in your hands. |
@sgoudham Also, there has been significant changes to highlight groups. So the original comment is outdated. markview.mp4 |
Is your feature request related to a problem? Please describe.
Hi, Is it possible to add colorscheme support for my plugin markview.nvim?
Describe the solution you'd like
It would be great if the colorscheme came with the highlight groups for the plugin.
You can check all the highlight groups used by the plugin here.
Describe alternatives you've considered
By default, the plugin will generate highlight groups based on the colorscheme. So, currently it looks like this.
Catppuccin frappe
Catppuccin latte
Catppuccin macchiato
Catppuccin mocha
Additional context
Not provided
The text was updated successfully, but these errors were encountered: