Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): make TabLine more readable #760

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

igorlfs
Copy link
Contributor

@igorlfs igorlfs commented Aug 14, 2024

Hello!

Currently, the TabLine foreground is too dark, barely readable with an even darker background:

image

After:

image

Copy link
Collaborator

@vollowx vollowx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! BTW I wonder if we should modify TabLineSel highlight to use the same bg as Normal and a text fg, in order to present a more modern look, similar to the default colorscheme.

@igorlfs
Copy link
Contributor Author

igorlfs commented Aug 15, 2024

We could make TabLine's background even darker by using crust. Coupled with TabLineSel = { link = "Normal" }, here's how it looks:

image

Thoughts?

@vollowx
Copy link
Collaborator

vollowx commented Aug 16, 2024

make TabLine's background even darker by using crust

That make the selected one stand out, looks really nice, and we should also modify TabLineFill to use the same crust bg

@vollowx vollowx merged commit 4fd72a9 into catppuccin:main Aug 20, 2024
9 checks passed
@igorlfs
Copy link
Contributor Author

igorlfs commented Aug 26, 2024

That make the selected one stand out, looks really nice, and we should also modify TabLineFill to use the same crust bg

Hey! I guess it'd be somewhat nice to have the fill with a different color. That's not very common within neovim, but feels more modern IMO. Perhaps @mehalter could have some input, since he (re)introduced TabLineFill some weeks ago.

@mehalter
Copy link
Contributor

I don't have too much opinion here. If there is a good other color to use then that's probably good if it is more modern. Without it in there at all it was quite distracting so as long as there's a good choice I'm good with it :) plus if I disagree it's easy enough to change locally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants