Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use "flavor" and "color" spellings, update sass syntax #138

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

uncenter
Copy link
Member

We use a mix of "flavor" and "flavour", this switches to always using "flavor" (as is the standard across the org now iirc). Same with "color". I also updated some Sass variable naming to make more sense - $color is now $colors in some places.

Additionally, this PR removes most (not all, the hljs lib will need to be updated later) of the warnings from https://sass-lang.com/documentation/breaking-changes/import/.

@sgoudham
Copy link
Contributor

We use a mix of "flavor" and "flavour", this switches to always using "flavor" (as is the standard across the org now iirc).

Can I just veto you on this :kekw:

Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One day I'm going to change ctp/ctp back to using flavours.

@sgoudham sgoudham merged commit fa0912e into catppuccin:main Nov 15, 2024
1 check passed
@uncenter uncenter deleted the cleanup branch November 15, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants