Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI Normal and Bright colors are the same #28

Closed
mrp52 opened this issue Jan 5, 2025 · 4 comments · May be fixed by #29
Closed

ANSI Normal and Bright colors are the same #28

mrp52 opened this issue Jan 5, 2025 · 4 comments · May be fixed by #29

Comments

@mrp52
Copy link

mrp52 commented Jan 5, 2025

Please see attached screenshot of iTerm2 (left) and Ghostty (right) and their respective fastfetch output.

Note that both iTerm2 and Ghostty are using Catppuccin Mocha. iTerm2 is using the unmodified catppuccin-mocha.itermcolors whereas Ghostty is using theme = catppuccin-mocha set in its config file as the theme is built in. Also note the red boxes were edited into the screenshot obviously and not part of the terminal output :)

As you can see in the coloured bars rendered by fastfetch the output is different. Ghostty is rendering them correctly with the bottom row using the Bright ANSI color. iTerm2, for some reason, has the same value for both Normal and Bright ANSI colors.

In my personal opinion I feel the iTerm2 theme is wrong and Ghostty's theme is correct.

However I do not know if this is just a bug/oversight/mistake or as designed by the Catppuccin iTerm2 theme maintainer(s)? So before I spend time posting the correct values I figured it made more sense to ask if this is how the Catppuccin maintainers want the iTerm2 theme to look? And if so why?

image
@uncenter
Copy link
Member

uncenter commented Jan 5, 2025

The bright colors have historically been the same as the normal ones. A recent update to the palette introduced bright color variants, but those have not made their way into the ports yet. The Ghostty theme you are using is not maintained by us, but in our port of Ghostty catppuccin/ghostty#7 would fix this.

@mrp52
Copy link
Author

mrp52 commented Jan 5, 2025

Here is a "quick fix" I did to the iTerm theme to use the Ghostty values for ANSI Bright so that they are consistent.

SCR-20250105-pjue-2

@mrp52
Copy link
Author

mrp52 commented Jan 5, 2025

The bright colors have historically been the same as the normal ones. A recent update to the palette introduced bright color variants, but those have not made their way into the ports yet. The Ghostty theme you are using is not maintained by us, but in our port of Ghostty catppuccin/ghostty#7 would fix this.

Ah okay thanks for pointing me to this, I didn't see it when looking at open issues.

So I guess just wait until these new Bright varients are released? In the mean time I fixed it for my own setup (as you can see in my previous post which I just happened to post before I was aware of your reply) but as there is already work in progress on this I won't waste anyones time submitting a PR with duplicate work. Thanks uncenter :)

I will close this out as no need for it to stay open.

@mrp52 mrp52 closed this as completed Jan 5, 2025
@mrp52
Copy link
Author

mrp52 commented Jan 5, 2025

Figured just in case anyone wants the theme I am using in the above "fixed" screenshot before the fixes are released as part of the proper theme I have attached the Catppuccin Mocha only theme exported from iTerm2. Note as it is only the Mocha theme it doesn't have Light/Dark entries which just causes problems in iTerm2 anyway with its 'dynamic' theme switching. So this will always be a dark Mocha theme regardless of if you're in light or dark mode.

catppuccin-mocha-ansi.itermcolors.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants