Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't convert a link in a table in markup language. #22

Closed
lyenliang opened this issue Jul 24, 2023 · 4 comments
Closed

Can't convert a link in a table in markup language. #22

lyenliang opened this issue Jul 24, 2023 · 4 comments

Comments

@lyenliang
Copy link

lyenliang commented Jul 24, 2023

Hi, I found that I can't convert a link in a table using jira2markdown.convert().

Here's my code:

import jira2markdown

markup = '||aa||bb||cc||dd||\n|row1|row1-1|row1-2|row1-3[mylink|https://www.google.com]|'
result = jira2markdown.convert(markup)
print(result) # shows '|aa|bb|cc|dd|\n|-|-|-|-|\n|row1|row1-1|row1-2|row1-3|\n'

As you can see from the result above, the link [mylink|https://www.google.com] disappears after the conversion.

I use python 3.8.17 in macOS Monterey 12.6 to run the above code.

And I use the latest version(0.3.4) of jira2markdown.

This error doesn't occur when I run it in macOS Ventura 13.4.1.

How can I run jira2markdown correctly in macOS Monterey 12.6?

What are the dependent libraries of jira2markdown?

@catcombo
Copy link
Owner

Hi @lyenliang,

thanks for the issue and reproducible example. I tested it on my local machine. The issue isn't related to an OS. The pyparsing library that I use internally has been updated to version 3.1. There are API changes that I need to check. Some of the tests are already failing locally, which means more places may be affected.

In the meantime, you can still use jira2markdown, but you need to install version 3.0.9 of the pyparsing library. I'll try to find a time and fix the issues ASAP.

@lyenliang
Copy link
Author

Thank you for your information. I just downgraded my pyparsing from 3.1.0 to 3.0.9. And this solves my problem.

@catcombo
Copy link
Owner

It looks like a bug in the SkipTo operator. I've opened an issue in the pyparsing repository pyparsing/pyparsing#500 I also released version 0.3.5 to temporarily fix this problem by pining the pyparsing version to 3.0.9.

@catcombo
Copy link
Owner

The bug was fixed by pyparsing team. I released a version 0.3.6 to unpin pyparsing version in dependencies. @lyenliang thank you once again for the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants