Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC3966 ;name:value vs ;name=value #217

Closed
cdunn opened this issue May 29, 2018 · 2 comments
Closed

RFC3966 ;name:value vs ;name=value #217

cdunn opened this issue May 29, 2018 · 2 comments

Comments

@cdunn
Copy link

cdunn commented May 29, 2018

Came across an incompatibility with another library I was using and thinking this is a bug?

const [name, value] = part.split(':')

https://www.ietf.org/rfc/rfc3966.txt
isdn-subaddress = ";isub=" 1uric
extension = ";ext=" 1
phonedigit
context = ";phone-context=" descriptor

happy to submit pr if you agree with the issue of using '=' vs ':'

@catamphetamine
Copy link
Owner

Oh.
Not sure why I did it.
Looks like a big change across several files/tests.
Thanks, I'll do it.

@catamphetamine
Copy link
Owner

Fixed in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants