function definitions and naming convention

[ak4t0sh]

As described in https://docs.moodle.org/dev/Plugin_files#lib.php :

All the plugin's internal logic should be implemented in the auto-loaded classes or in the locallib.php file.

So your functions defined in index.php should be moved to locallib.php

Moreover to prevent namespace collision you should always use frankenstyle style for your constants and function's name (https://docs.moodle.org/dev/Coding_style#Functions_and_Methods, https://docs.moodle.org/dev/Coding_style#Constants)

[danmarsden]

@boGitsIT - looks like you missed this one too? - I've commented in-line on the files in your pull request.

[danmarsden]

just one remaining issue here - process_data_field - ideally like to see that function removed completely and rewritten to build the sql using normal moodle processes rather than this helper function.