Undefined strings for tmp directory

[michael-milette]

What happened?

During an upgrade of the plugin (most recent version last updated in November 2024 on GitHub) in Moodle 4.1 (English), I noticed that strings are undefined / undefined:

Here is a list of the missing strings:

• tempdir
• tempdirdefault
• tempdir_help

Let me know if you have any questions.

Best regards,

Michael Milette

[danmarsden]

Those strings appear to.be there to me.. do you have local changes to the lang string file that have caused a merge conflict which wasn't fixed properly?

[danmarsden]

@Limekiller @keevan the tempdirdefault value there doesn't look like it should have landed in the lang strings to me. We should pull that out too.

[keevan]

Thanks for catching that one @danmarsden, I've pushed a PR which should fix this in 404 and 39 branches.

[danmarsden]

Cool thanks!

[michael-milette]

Those strings appear to.be there to me.. do you have local changes to the lang string file that have caused a merge conflict which wasn't fixed properly?

I have no local changes to the strings. It was working fine before I upgraded the plugin from a version from October 2023.

[danmarsden]

yeah - sorry @michael-milette you were correct they were missing in one of the branches - @keevan pushed a fix through last night though so it should be sorted now.

thanks!