Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-integrate nukes into analytical outputs #1503

Closed
Tracked by #1497
zaneselvans opened this issue Mar 1, 2022 · 0 comments · Fixed by #1518
Closed
Tracked by #1497

Re-integrate nukes into analytical outputs #1503

zaneselvans opened this issue Mar 1, 2022 · 0 comments · Fixed by #1518
Assignees
Labels
bug Things that are just plain broken. eia923 Anything having to do with EIA Form 923 output Exporting data from PUDL into other platforms or interchange formats.

Comments

@zaneselvans
Copy link
Member

  • Generation fuel table is split into nukes and non-nukes
  • Some output tables use the generation_fuel_eia923 table and assume that it contains ALL the generation_fuel records. Which is now false. E.g. MCOE and net generation allocation. However, these dependent outputs don't realize that they are now working with incomplete data.
  • One option: concatenate the gf and gfn tables and recreate the previously existing generation_fuel_eia923 output table.
  • Another option, create 3 (no nukes, with nukes, combined).
  • Concern: Are we going to just lose the generator level granularity that we've got in the nukes? They're not many of the records, but they are 20% of the overall generation. May want to address that. Should create an issue to fix this and integrate that granularity into the net generation allocation process etc.

Example from CG implemented in the DBCP context:

    # generate the generation fuel table & its nuclear counterpart
    # in order to SQUISH THEM together and reassigned this squished
    # version of the gen fuel tables into the cached pudl_out table
    # this way the subsequent outputs which use the gen fuel table
    # *cough cough* MCOE have the nuclear generators in there.
    gf = pudl_out.gf_eia923()
    # only add it in if the nuclear ID isn't in the columns
    # which indicates that these two tables have not been SQUISHED
    if 'nuclear_unit_id' not in gf:
        gfn = pudl_out.gfn_eia923()
        pudl_out._dfs['gf_eia923'] = pd.concat([gf, gfn])
@zaneselvans zaneselvans added bug Things that are just plain broken. eia923 Anything having to do with EIA Form 923 output Exporting data from PUDL into other platforms or interchange formats. labels Mar 1, 2022
@zaneselvans zaneselvans self-assigned this Mar 1, 2022
@zaneselvans zaneselvans mentioned this issue Mar 2, 2022
22 tasks
@zaneselvans zaneselvans linked a pull request Mar 10, 2022 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that are just plain broken. eia923 Anything having to do with EIA Form 923 output Exporting data from PUDL into other platforms or interchange formats.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant