Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android build failure after inclusion of std::filesystem #3280

Closed
scarf005 opened this issue Sep 27, 2023 · 1 comment · Fixed by #3289
Closed

android build failure after inclusion of std::filesystem #3280

scarf005 opened this issue Sep 27, 2023 · 1 comment · Fixed by #3289
Assignees
@scarf005

Comments

@scarf005
Copy link
Member

https://github.com/cataclysmbnteam/Cataclysm-BN/actions/runs/6320334183/job/17162700684

android build fails since #3270 becaues NDK doesn't support C++17 filesystem

thankfully DDA has a solution to this: CleverRaven/Cataclysm-DDA#64305
@scarf005 scarf005 self-assigned this Sep 27, 2023
@olanti-p
Copy link
Contributor

olanti-p commented Sep 27, 2023 •
edited
Loading

This should have been caught by the Android build check, but it didn't run for some reason
https://github.com/cataclysmbnteam/Cataclysm-BN/actions/runs/6312551327/job/17138831394?pr=3270

Edit: and neither did MSVC and MinGW builds, which were supposed to check how it handles UTF-8 paths -_-

This was referenced Sep 27, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scarf005 scarf005

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: bump android ndk scarf005/Cataclysm-BN
2 participants
@scarf005 @olanti-p