Possibly a bug when checking if awq_ext is installed

[BenjaminBossan]

Regarding these lines:

AutoAWQ/awq/modules/linear/gemm.py

Lines 7 to 12 in 4fc6cc0

	try:
	import awq_ext # with CUDA kernels (AutoAWQ_kernels)
	AWQ_INSTALLED = True
	except:
	AWQ_INSTALLED = False

and

AutoAWQ/awq/modules/linear/gemm.py

Line 66 in 4fc6cc0

if awq_ext is None:

It seems that either, in the first block awq_ext = None should be set or in the second, if AWQ_INSTALLED should be checked.

Also just a small note, try: import foo; except ... can be dangerous as the import can trigger side-effects, though it's not super likely, just something to be aware of.

[casper-hansen]

Hi @BenjaminBossan, thanks for raising this issue. Just trying to understand what you are thinking. Would the following be better?

AWQ_INSTALLED = None
 try: 
     import awq_ext  # with CUDA kernels (AutoAWQ_kernels) 
  
     AWQ_INSTALLED = True 
 except: 
     AWQ_INSTALLED = False 

[BenjaminBossan]

Solution 1, l.12:

try:
    import awq_ext  # with CUDA kernels (AutoAWQ_kernels)

    AWQ_INSTALLED = True
except:
    AWQ_INSTALLED = False
+   awq_ext = None

or solution 2, line 66:

-        if awq_ext is None:
+        if not AWQ_INSTALLED:

Otherwise, we get a name error in l.66 if awq_ext could not be imported.