Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"SignedBlock needs to be renamed as BlockWithSignatures" related change in casper-client-rs #229

Open
devendran-m opened this issue Jan 25, 2025 · 1 comment
Open

"SignedBlock needs to be renamed as BlockWithSignatures" related change in casper-client-rs #229

devendran-m opened this issue Jan 25, 2025 · 1 comment
Assignees
@igor-casper

Comments

@devendran-m
Copy link

devendran-m commented Jan 25, 2025 •
edited
Loading

This issue arises from the analysis of the casper-sidecar bug #396 reported by Ihor at MAKE.

In analysing the bug, the team identified that SignedBlock must be renamed to BlockWithSignatures in casper-node and the related change should be carried out in casper-client-rs.

Related casper-node ticket - casper-network/casper-node#5079
@wojcik91 wojcik91 self-assigned this Jan 28, 2025
@wojcik91
Copy link
Collaborator

casper-client uses its own JsonBlockWithSignatures struct introduced in #107.
There are no uses of SignedBlock which would need to be updated.

@wojcik91 wojcik91 assigned igor-casper and unassigned igor-casper and wojcik91 Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igor-casper igor-casper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wojcik91 @devendran-m @igor-casper