Remove homebrew-fork Checksum class and refactor
#8388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* perform actual checksum calculation within download.rb * use an accessor named sha256 instead of sums for checksum data * migrate checksum-specific exceptions out of homebrew-fork
rolandwalker
added
the
core
rolandwalker
added a commit
that referenced
this pull request
Dec 24, 2014
Remove homebrew-fork `Checksum` class and refactor
|
Post-merge, I agree. This is in line with my original intentions, which would be to simplify checksums and move them into a |
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
download.rbsha256instead ofsumsfor checksum dataThe
sumsaccessor was a relic from when Casks could contain any ofmd5,sha1, etc. Thesumsarray was more extensible (if we change checksums again) but balancing against the clarity of naming accessors after the relevant stanzas, I opted for the latter.The refactor is incomplete. We may want to spin checksums out of
download.rband/or combine them with GPG checks.cc @ndr-qef