Adjust brew cask doctor for homebrew-fork
#8221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...constant. Instead extract it from the brew CLI, and consider removing it from our doctor output entirely.
Instead extract it from the brew CLI, and consider removing it from our doctor output entirely.
Instead extract it from the brew CLI, and consider removing it from our doctor output entirely.
tweak doctor's warnings/annotations on `$LOAD_PATH` elements
rolandwalker
added
the
core
rolandwalker
added a commit
that referenced
this pull request
Dec 18, 2014
Adjust `brew cask doctor` for homebrew-fork
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #8089 we are pulling in code from an incorporated Homebrew fork.
This means that some of the output of
brew cask doctorwas deceptive. After this PR, we no longer reportHOMEBREW_*constants derived from our fork, but read them at runtime by executing egbrew --cellar.This also removes a direct dependency on the fork.
It is debatable whether we should continue to provide this info in "doctor", as it no longer has the same degree of influence on the execution of
brew cask. But it does no harm, and we can revisit it later.