-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest brew update && …
when handling errors or missing methods
#8072
Conversation
This helps cut trivial issues that would be easily fixable by doing `brew update && …`.
def self.error_message_with_suggestions | ||
<<-EOS.undent | ||
#{ Tty.reset } | ||
#{ Tty.white }Most likely, this means you have #{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only question is what this empty #{}
does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve been taught that lines longer than 80 chars are bad.
Sometimes this makes me feel so guilty that I even try to follow this rule in herestrings. 😊
Am I free to ignore this rule in herestrings? Or maybe you happen to know a less confusing way to soft-wrap long lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it is a clever trick.
You are free to do as you please, in heredocs and elsewhere. We can adopt a style re: wrapping across the codebase if it benefits you. I tend to let code run wide, which attracts criticism.
Suggest `brew update && …` when handling errors or missing methods
Thanks for reviewing and for the comments! Oh, I’m fine with the codebase as it stands. Should we ever commit to any stylistic rules (as the number of backend devs – hopefully – grows with the project), I’ll be happy to adhere to them! |
It is merely a placeholder used in the screenshot. |
Ah, good. I couldn’t find it in the PR itself, so I was wondering if it was there from before. |
@ndr-qef You’re correct, thanks for clarifying 😊 @vitorgalvao I temporarily placed a |
As @ndr-qef and @rolandwalker suggested on IRC.
This is supposed to help cut trivial issues that would be easily fixable by doing
brew update && …
etc.Also, splitting unit tests in two to keep one from triggering the other.