Open.popen3 does not set $?
#5520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This is possibly the cause of other glitches such as random failures on Travis. Ruby 1.8 popen3 does set global $? for the exit status, Ruby 1.9 and above does not. For Ruby 2.0 users (Mavericks and above with recent Homebrew), success or failure of the current external command was determined by the exit status of some previous command. Closes Homebrew/homebrew-cask-fonts#186
rolandwalker
added a commit
that referenced
this pull request
Jul 28, 2014
Open.popen3 does not set `$?`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is possibly the cause of other glitches such as random
failures on Travis.
Ruby 1.8
popen3does set global$?for the exit status, Ruby1.9 and above does not. For Ruby 2.0 users (Mavericks and
above with recent Homebrew), success or failure of the current
external command was determined by the exit status of some
previous command.
For newer Rubies, we should use the fourth parameter from
popen3to get the exit status.
Closes Homebrew/homebrew-cask-fonts#186
Edit: rewrote this comment to match the amended commit message