Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclamation in comments generates error: Unknown start of token #294

Closed
runeimp opened this issue Jan 9, 2018 · 2 comments
Closed

Exclamation in comments generates error: Unknown start of token #294

runeimp opened this issue Jan 9, 2018 · 2 comments
Labels

Comments

@runeimp
Copy link

runeimp commented Jan 9, 2018

Now with v0.3.6 (worked in prior 0.3.x versions) I'm getting

error: Unknown start of token:
  |
3 | # Cleanup around here!
  | ^

In any Justfile comment that has an exclamation in it that isn't right after the comment marker. If I have it right after the comment marker I get

error: `#!` is reserved syntax outside of recipes
  |
3 | #! Cleanup around here
  | ^

The second one makes sense, after thinking about it and realizing it's part of output. Was the change to not allow exclamations in comments intentional or is this a bug?

Example Justfile

# Line 1 Comment

# Cleanup around here!
@runeimp runeimp changed the title Unknown Start of Token -- Exclamation in Comments Exclamation in comments generates _error: Unknown start of token_ Jan 10, 2018
@runeimp runeimp changed the title Exclamation in comments generates _error: Unknown start of token_ Exclamation in comments generates error: Unknown start of token Jan 10, 2018
@casey casey added the bug label Jan 23, 2018
@casey
Copy link
Owner

casey commented Jan 23, 2018

Thanks for the report, and sorry it took me so long to fix it!

I just pushed out a release with the patch:
https://github.com/casey/just/releases/tag/v0.3.7

@runeimp
Copy link
Author

runeimp commented Jan 23, 2018

Thanks @casey ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants