Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crater for Just #251

Closed
casey opened this issue Nov 17, 2017 · 2 comments · Fixed by #406
Closed

Crater for Just #251

casey opened this issue Nov 17, 2017 · 2 comments · Fixed by #406
Assignees

Comments

@casey
Copy link
Owner

casey commented Nov 17, 2017

There are a lot of justfiles on github, and it would be nice to leverage them to make sure that existing justfiles aren't broken by future changes tojust.

I'm imagining a tool that would, for a new version of just:

  • download all files on named justfile or Justfile
  • check that all files are tokenized identically under the new and old versions
  • check that all files are parsed identically under the new and old versions
  • check that all files produce identical dry-runs under new and old versions

Caldera would be an appropriate name. It will probably need a blacklist for those files which are called justfile but which aren't actually justfiles.

@rollcat
Copy link

rollcat commented Sep 22, 2018

It will probably need a blacklist for those files which are called justfile but which aren't actually justfiles.

On the lower layer, it should be sufficient to generate a report for given version of just, some just-version. If it fails to parse today, it shouldn't be a problem tomorrow.

A higher layer would have to track tuples of (something-that-looks-like-justfile, just-version, report), and only raise red flags when there's a regression - something that worked with just-version is now broken in just-version+1.

Then there's no need for a hardcoded list - both whitelists and blacklists suck.

@casey
Copy link
Owner Author

casey commented Apr 16, 2019

It exists now!

https://github.com/casey/janus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants